feat: Allow to inline collection member columns for sampling#5
Merged
Conversation
Andreas Albert (AndreasAlbertQC)
approved these changes
Apr 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1776 1788 +12
=========================================
+ Hits 1776 1788 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When providing overrides for column values in
Collection.sample, it would be nice to optionally inline columns of members. What do I mean by that? Imagine that you have two membersin a collection
For sampling you can currently do
However, it would be nice to "inline" the column values since it is clear what member
yandzbelong to, i.e. doThis significantly reduces the amount of typing required to use overrides.
Changes
inline_for_sampling: boolfor thedy.CollectionMemberannotation which can be used to inline the columns of a collection member